Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riot-web: fallback to example config #64687

Merged
merged 1 commit into from Jul 13, 2019
Merged

riot-web: fallback to example config #64687

merged 1 commit into from Jul 13, 2019

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Jul 12, 2019

Motivation for this change

Since 1.2.2, specifying defaults seems to be required for the app to start.
This fixes issue #64543 (riot-desktop starts and just displays "Riot is misconfigured").
The problem isn't apparent when the user is already logged in.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC: @bachp @nyanloutre

@pacien
riot-web: fallback to example config
9e9cc36 
Since 1.2.2, specifying defaults seems to be required for the app to start.
bachp
bachp approved these changes Jul 13, 2019
View reviewed changes
Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks resonable.

worldofpeace
worldofpeace approved these changes Jul 13, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things I've done to test

@worldofpeace worldofpeace merged commit 0394aae into NixOS:master Jul 13, 2019
@pacien pacien mentioned this pull request Jul 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp bachp approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pacien @bachp @worldofpeace