Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docs for postgresql plugins #64899

Merged
merged 7 commits into from Jul 21, 2019

Conversation

danbst
Copy link
Contributor

@danbst danbst commented Jul 16, 2019

Rendered
Screenshot from 2019-07-16 14-56-19

Related: #58251 (alternative fix for that issue), #38698 (documentation part), #38616 (finally missing docs are added), #21042 (fixes issue), #54319 (the PR which introduced the need for this doc)

Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor nitpicks

nixos/modules/services/databases/postgresql.nix Outdated Show resolved Hide resolved
nixos/modules/services/databases/postgresql.xml Outdated Show resolved Hide resolved
nixos/modules/services/databases/postgresql.xml Outdated Show resolved Hide resolved
nixos/modules/services/databases/postgresql.xml Outdated Show resolved Hide resolved
nixos/modules/services/databases/postgresql.xml Outdated Show resolved Hide resolved
nixos/modules/services/databases/postgresql.xml Outdated Show resolved Hide resolved
danbst and others added 6 commits July 17, 2019 07:26
Co-Authored-By: Mario Rodas <marsam@users.noreply.github.com>
Co-Authored-By: Mario Rodas <marsam@users.noreply.github.com>
Co-Authored-By: Mario Rodas <marsam@users.noreply.github.com>
Co-Authored-By: Mario Rodas <marsam@users.noreply.github.com>
Co-Authored-By: Mario Rodas <marsam@users.noreply.github.com>
Co-Authored-By: Mario Rodas <marsam@users.noreply.github.com>
@danbst danbst merged commit caa0f82 into NixOS:master Jul 21, 2019
@danbst danbst deleted the postgresql-plugins-docs branch July 21, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants