Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: drop absolute Python path #64903

Merged
merged 1 commit into from Jul 17, 2019
Merged

bazel: drop absolute Python path #64903

merged 1 commit into from Jul 17, 2019

Conversation

abbradar
Copy link
Member

Motivation for this change

Without this Bazel always picks Python 3 which breaks Python 2 packages.
Strangely enough just dropping this patch works, with all bazel.tests
passing. Tested this on Python 2 Tensorflow build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Profpatsch @NinjaTrappeur

@abbradar
bazel: drop absolute Python path
bd98f35 
Without this Bazel always picks Python 3 which breaks Python 2 packages.
Strangely enough just dropping this patch works, with all `bazel.tests`
passing.
@abbradar abbradar requested a review from Profpatsch July 16, 2019 12:43
@abbradar abbradar mentioned this pull request Jul 16, 2019
Merged
10 tasks
@Profpatsch Profpatsch requested a review from kalbasit July 16, 2019 14:33
@Profpatsch
Copy link
Member

@GrahamcOfBorg build bazel.tests

Profpatsch
Profpatsch approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@Profpatsch Profpatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kalbasit kalbasit merged commit c481351 into NixOS:master Jul 17, 2019
@kalbasit kalbasit mentioned this pull request Jul 20, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@Profpatsch Profpatsch Profpatsch approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abbradar @Profpatsch @kalbasit