Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-appservice-irc: Init at 0.12.0 #64791

Closed
wants to merge 2 commits into from
Closed

matrix-appservice-irc: Init at 0.12.0 #64791

wants to merge 2 commits into from

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Jul 15, 2019

Motivation for this change

I hope I did everything correct here. Node modules are hard :/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented Jul 16, 2019

@GrahamcOfBorg build matrix-appservice-irc

@dasJ
Copy link
Member Author

dasJ commented Jul 16, 2019

Oh, should I also put it to all-packages?

@dasJ dasJ closed this Jul 28, 2019
@dasJ dasJ deleted the node-matrix-irc branch July 28, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dasJ @mmahut