Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: 67.0.4 -> 68.0, firefox-esr: 60.7.2esr -> 68.0esr, rust-cbindgen: 0.8.3 -> 0.8.7 (v2) #64742

Merged
merged 5 commits into from Jul 16, 2019

Conversation

andir
Copy link
Member

@andir andir commented Jul 14, 2019

Motivation for this change

Newer revision of #64733 since I am not allowed to update the source branch.

  • Critical security fixes
  • Other improvements
  • ESR is now based on version 68.

https://www.mozilla.org/en-US/firefox/68.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2019-21/

Compiling all the versions now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Jul 15, 2019

I suppose the huge rebuilds (i.e. nss bump) can't be separated, right? (22k is quite a lot)

@vcunat
Copy link
Member

vcunat commented Jul 15, 2019

In any case, I added the nss commit 442fd85 to staging-next, and I hope it will be mergeable very fast. In case we find some other regression in there, we can e.g. proceed with merging this PR directly to master anyway.

@andir
Copy link
Member Author

andir commented Jul 15, 2019

@vcunat
Those bumps are a dependency of the newer firefox version. We could in theory split them. Whenever you feel like staging-next doesn't yield any new errors feel free to merge.

@vcunat
Copy link
Member

vcunat commented Jul 15, 2019

Added 60.8.0: that branch should be supported for a couple more months, though perhaps with less visibility (I found no release notes like for the new ESR). I browsed with it shortly (built atop staging-next), and it seemed fine just as the other two here.

EDIT: here are the release notes https://www.mozilla.org/en-US/firefox/60.8.0/releasenotes/

vcunat pushed a commit that referenced this pull request Jul 15, 2019
(cherry picked from commit 442fd85)
Fresh nss will be needed for further Firefox updates; /cc PR #64742
@andir
Copy link
Member Author

andir commented Jul 15, 2019

I started working on a backport to 19.03 (https://github.com/andir/nixpkgs/commits/19.03/firefox-68.0). Still running all the builds to see if I didn't break things in the process.

@andir
Copy link
Member Author

andir commented Jul 15, 2019

@vcunat the results on staging-next look fine. Do you see any reason not to merge this in yet?

@vcunat
Copy link
Member

vcunat commented Jul 15, 2019

Well, the yaml problem should be easy now; I hope the couple thousand of unrestartable abortions will disappear... and that might be all from the larger regressions, at a quick glance.

@vcunat
Copy link
Member

vcunat commented Jul 16, 2019

Your backports seemed to work fine for me, so I pushed them to 19.03.

@vcunat
Copy link
Member

vcunat commented Jul 16, 2019

Except that rustc backport won't build on darwin: https://hydra.nixos.org/build/96319842

@vcunat vcunat merged commit 538c8ae into NixOS:master Jul 16, 2019
vcunat added a commit that referenced this pull request Jul 16, 2019
@andir andir deleted the firefox-68.0 branch July 16, 2019 22:42
@jabranham
Copy link
Contributor

Firefox 68 still isn't in nixos-unstable. Is there something we can do to speed this up?

@vcunat
Copy link
Member

vcunat commented Jul 22, 2019

Some NixOS tests were broken (some even for about a week), but apparently they got fixed today. I expect both channels to update within a couple hours.

@jabranham
Copy link
Contributor

jabranham commented Jul 22, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants