Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r19.03] squid, squid4: add patches fixing CVE-2019-13345 #64745

Merged
merged 2 commits into from Jul 15, 2019
Merged

[r19.03] squid, squid4: add patches fixing CVE-2019-13345 #64745

merged 2 commits into from Jul 15, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jul 14, 2019

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-13345

See also #64744

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

spacekookie
spacekookie reviewed Jul 14, 2019
View reviewed changes
pkgs/servers/squid/4.nix
@@ -9,6 +9,14 @@ stdenv.mkDerivation rec {
sha256 = "10pfx44mps5ng1806rqdwx8jv8b2n25kjvx37dcd4x2mgzdfc1a9";
};

patches = [
(fetchpatch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same note as on the other PR (#64744 (comment))

@ofborg ofborg bot requested review from 7c6f434c and fpletz July 14, 2019 22:05
@7c6f434c 7c6f434c merged commit 0d0cb24 into NixOS:release-19.03 Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacekookie spacekookie spacekookie left review comments

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @spacekookie @7c6f434c