Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: How to change FIFO clock dommains? #151

Closed
ydnatag opened this issue Jul 14, 2019 · 4 comments
Closed

Question: How to change FIFO clock dommains? #151

ydnatag opened this issue Jul 14, 2019 · 4 comments
Labels
question

Comments

@ydnatag
Copy link

ydnatag commented Jul 14, 2019

Hello
I'm starting using nMigen and i want instantiate the AsyncFifoBuffered library. I found that the fifo clock domain are read and write, and i need to connect them to domains called input and output.

  • Is there any easy way to make this connection?
  • Should libraries have an argument to specify the domain names?

Thx.
Andres
@peteut
Copy link
Contributor

peteut commented Jul 14, 2019

@andresdemski you are looking for

m.submodules += DomainRenamer({"read": "input", "write": "output"})(<your-module>)

@ydnatag
Copy link
Author

ydnatag commented Jul 15, 2019 •
edited

With this approach, you always need to know the implementation (or it needs to be well documented). Add an argument specifying domain names in libraries should be a good idea.

@whitequark
Copy link
Contributor

@andresdemski I entirely agree, #97 is the tracking issue for adding an explicit argument.

@ydnatag
Copy link
Author

ydnatag commented Jul 16, 2019

Ok, Thanks you!

@ydnatag ydnatag closed this as completed Jul 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@whitequark @peteut @ydnatag