Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-fonts: 2018-07-13 -> 2019-07-14 #64743

Merged
merged 2 commits into from Jul 23, 2019

Conversation

spacekookie
Copy link
Member

Motivation for this change

This PR updates the google-fonts package to a newer version.
There's some more post-processing to be done because of duplicate
fonts. The reasoning is documented and it generally seems to work.

I'm also removing the fixed output derivation hashes. Generally
they don't really add much in terms of reproducable builds. They
make updating the package more annoying and cumbersome. Plus, there's
the issue where if the build starts failing at some point, this will
be shadowed by the fact that people will just get hydra cached versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link

ghost commented Jul 21, 2019

LGTM

@worldofpeace worldofpeace merged commit 18cbb76 into NixOS:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants