Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squid, squid4: bump/add patch fixing CVE-2019-13345 #64744

Merged
merged 2 commits into from Jul 15, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jul 14, 2019

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-13345

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -9,6 +9,14 @@ stdenv.mkDerivation rec {
sha256 = "1n4f55g56b11qz4fazrnvgzx5wp6b6637c4qkbd1lrjwwqibchgx";
};

patches = [
(fetchpatch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd probably be nicer to keep the patch in nixpkgs itself, just to minimise network access dependencies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm kind of on the fence with this one - but the general policy these days seems to be only add the patch to nixpkgs if it's unavoidable. This is made less painful because once packages make it into nixpkgs the nix cache grabs a copy of all their http fetches. I can't remember the last time my machine had to fetch a patch from a third party url except when I'm reviewing unmerged work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants