Change test_designMode to check for empty string instead of br tag #17809
Conversation
wpt-pr-bot
requested review from
andreastt,
AutomatedTester,
mjzffr,
shs96c and
whimboo
|
I think that this looks fine. But @andreastt added that part, so Andreas if you could check that too, we can get this merged. |
|
Any updates on this? Would liked this pushed through before I forget about it |
There was a problem hiding this comment.
As mentioned in my last commit it looks fine, and as such I will give r+. If @andreastt doesn't respond soon, we should assume its fine and can be merged.
|
Would it be possible to merge it now that sufficient time has passed without response? |
|
Yes, I think we should finally get this merged. Thanks for pinging. |
|
As it turned out and further discussed on https://bugzilla.mozilla.org/show_bug.cgi?id=1573801, the PR should have not been merged. After the comment of @andreastt on that bug I checked the behavior of Firefox, Chrome, and Safari. All of them show a Could someone please help with a backout of this patch? Thanks |
|
@julianrkung Please feel free to file an issue for further discussion. This PR cannot be reopened. |
|
I opened another PR that accepts both |
…br tag (web-platform-tests#17809)" (web-platform-tests#18421) This reverts commit 0ca74f4.
test_designMode incorrectly checks that the innerHTML after an element_clear is a
<br>tag. Instead, the innerHTML property should be an empty string according to the W3C spec here: element clear.The clear should follow the "To clear a content editable element" subroutine, which states:
Nowhere in the spec for element clear is the insertion of a
<br>tag mentioned, so rather than accept both answers, to be spec compliant only an empty string should be accepted.