Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt-box-editor: init at unstable-2019-07-12 #64677

Merged
merged 1 commit into from Jul 14, 2019
Merged

qt-box-editor: init at unstable-2019-07-12 #64677

merged 1 commit into from Jul 14, 2019

Conversation

costrouc
Copy link
Member

latest unstable version is only one to build with tesseract4 and qt5

Motivation for this change

LGTM I have tested that the binary works for my OCR training

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc
Copy link
Member Author

Result of nix-review pr 64677 1

1 package were build:
  • qt-box-editor

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build qt-box-editor

@worldofpeace
Copy link
Contributor

Build is failing on darwin.

@costrouc
Copy link
Member Author

I do not have any nice way of testing darwin. This was the error cp: -r not specified; omitting directory 'release/qt-box-editor-1.12rc1.app'. I have been using cp in the linux build since for some reason the binary is not being put in bin for the installPhase automatically. Do you know why this is?

@worldofpeace
Copy link
Contributor

worldofpeace commented Jul 13, 2019 •
edited

The qmake files lack an INSTALLS and a target.path so they don't install anything.

https://doc.qt.io/qt-5/qmake-advanced-usage.html#installing-files

@costrouc
Copy link
Member Author

@worldofpeace fixed! Thank you so much for the help

@costrouc
Copy link
Member Author

@GrahamcOfBorg build qt-box-editor

@costrouc costrouc mentioned this pull request Jul 14, 2019
Merged
@worldofpeace
Copy link
Contributor

Thanks @costrouc.

Just going to test the darwin build.

@GrahamcOfBorg build qt-box-editor

@worldofpeace
Copy link
Contributor

worldofpeace commented Jul 14, 2019 •
edited

Seems to build. I admittedly don't know that much about macos, so that could be the incorrect target.path.
But at least the build isn't broken.

@costrouc @worldofpeace
qt-box-editor: init at unstable-2019-07-12
ffaa9c8 
latest unstable version is only one to build with tesseract4 and qt5
@worldofpeace worldofpeace merged commit f48c9d4 into NixOS:master Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@costrouc @worldofpeace