Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pmacct: init at 1.7.3 #64849

Merged
merged 1 commit into from Dec 3, 2019
Merged

pmacct: init at 1.7.3 #64849

merged 1 commit into from Dec 3, 2019

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Jul 16, 2019 •
edited

Motivation for this change

Adding package for pmacct.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@0x4A6F 0x4A6F marked this pull request as ready for review August 22, 2019 16:49
@0x4A6F
Copy link
Member Author

0x4A6F commented Nov 8, 2019

@GrahamcOfBorg build pmacct

@c0bw3b c0bw3b merged commit a89c35d into NixOS:master Dec 3, 2019
@0x4A6F 0x4A6F deleted the master-pmacct branch December 3, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0x4A6F @c0bw3b