Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37: fix distutils C++ patch #64758

Closed
wants to merge 1 commit into from
Closed

python37: fix distutils C++ patch #64758

wants to merge 1 commit into from

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jul 15, 2019

Motivation for this change

Update distutils patch to the upstream changes.
See: python/cpython@6c0e0d1

Fixes #64615

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
python37: fix distutils C++ patch
cdece17 
Update distutils patch to the upstream changes.
See: python/cpython@6c0e0d1
@marsam marsam requested a review from FRidh as a code owner July 15, 2019 03:09
@veprbl
Copy link
Member

veprbl commented Jul 15, 2019

@GrahamcOfBorg build python37

vcunat pushed a commit that referenced this pull request Jul 15, 2019
@marsam @vcunat
python37: fix distutils C++ patch (PR #64758)
7094a1a 
Update distutils patch to the upstream changes.
See: python/cpython@6c0e0d1
@vcunat
Copy link
Member

vcunat commented Jul 15, 2019

Thanks! Pushed to staging-next, succeeds on Hydra and now being picked to staging-19.03.

@vcunat vcunat closed this Jul 15, 2019
vcunat pushed a commit that referenced this pull request Jul 15, 2019
@marsam @vcunat
python37: fix distutils C++ patch (PR #64758)
198a6bd 
Update distutils patch to the upstream changes.
See: python/cpython@6c0e0d1

(cherry picked from commit 7094a1a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @veprbl @vcunat