fly: init at 5.3.0 #64714
Merged
fly: init at 5.3.0 #64714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
reviewed
Jul 13, 2019
kalbasit
requested changes
Jul 13, 2019
| postInstall = '' | ||
| install -D -m 444 ${ | ||
| writeText "fly.bash" (builtins.readFile ./fly.bash) | ||
| } $out/share/bash-completion/completions/fly |
There was a problem hiding this comment.
Suggested change
| } $out/share/bash-completion/completions/fly | |
| install -D -m 444 fly.bash $out/share/bash-completion/completions/fly |
There was a problem hiding this comment.
@kalbasit Because fly.bash isn't present in the project's source, I had to implement this slightly differently: 9e465d2#diff-bd215dfd96e2fb6f91323ab49fa3563fR28
Add `fly` CLI for working with Concourse CI, and include Bash completions.
|
@GrahamcOfBorg build fly |
kalbasit
approved these changes
Jul 15, 2019
ivanbrennan
added a commit
to ivanbrennan/nixpkgs
that referenced
this pull request
Mar 28, 2021
The writeText argument is unused. It was originally used to copy a bash completion script into the derivation, but a different approach was chosen, and I simply forgot to remove the writeText argument. NixOS@78013b4 NixOS#64714 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
flyCLI for working with Concourse.Motivation for this change
There was no existing derivation for fly CLI.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)