Removing ES6 from WebDriver execute [async] script property tests #17824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To preserve compatibility with older user agents whose JavaScript engines do not implement ES6 constructs, in particular array destructuring, this PR refactors those constructs to be compatible with the older language syntax.
wpt-pr-bot
requested review from
andreastt,
AutomatedTester,
mjzffr,
shs96c and
whimboo
andreastt
approved these changes
Jul 15, 2019
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
…tests (web-platform-tests#17824) To preserve compatibility with older user agents whose JavaScript engines do not implement ES6 constructs, in particular array destructuring, this PR refactors those constructs to be compatible with the older language syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To preserve compatibility with older user agents whose JavaScript
engines do not implement ES6 constructs, in particular array
destructuring, this PR refactors those constructs to be compatible
with the older language syntax.