Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spago: init at 0.8.5.0 #64704

Closed
wants to merge 1 commit into from
Closed

spago: init at 0.8.5.0 #64704

wants to merge 1 commit into from

Conversation

Shou
Copy link
Contributor

@Shou Shou commented Jul 13, 2019

Credit to justinwoo/easy-purescript-nix.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

alexarice
alexarice reviewed Jul 13, 2019
View reviewed changes
Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The github page suggests installing this through npm. Would the existing node tools be a better way of installing this

pkgs/development/web/spago/default.nix Outdated Show resolved Hide resolved
pkgs/development/web/spago/default.nix Outdated Show resolved Hide resolved
pkgs/development/web/spago/default.nix Outdated
sha256 = "0r66pmjfwv89c1h71s95nkq9hgbk7b8h9sk05bfmhsx2gprnd3bq";
};

buildInputs = [ pkgs.gmp pkgs.zlib pkgs.ncurses5 pkgs.stdenv.cc.cc.lib ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure about the c compiler library package, perhaps this should be a native build input?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done this now.

@Shou
spago: init at 0.8.5.0
df32807 
Credit to [justinwoo/easy-purescript-nix][1].

[1]: https://github.com/justinwoo/easy-purescript-nix
@cdepillabout
Copy link
Member

I packaged spago in #74557.

However, this builds it from source and doesn't use the easy-purescript-nix approach.

If spago built from source breaks frequently, it might make sense to go back and use the easy-purescript-nix approach.

@Shou
Copy link
Contributor Author

Shou commented Mar 7, 2020

(I'm late but I'll close this now given the above)

@Shou Shou closed this Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarice alexarice alexarice left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shou @cdepillabout @alexarice