localstack: init at 0.9.6 #64760
localstack: init at 0.9.6 #64760
Conversation
There was a problem hiding this comment.
If some of the packages have very specific version needs, I would first:
- see if the package is following a version scheme such as semver so that you can widen the allowable range to include what the latest is.
- if it's mutually exclusive (such as a different major version with breaking changes), then I would bring in the whole nix expression under that directory.
- E.g you need pyyaml 3.13, then there would be a
python-modules/awscli/pyyaml_3.nixthat would include the expression to make that package.
- E.g you need pyyaml 3.13, then there would be a
- Or if the package is commonly used at a previous version such as pytest_4, then just add it to the top level with the version (E.g pytest_4)
pinning a lot of specific versions will make it really hard to maintain
|
ya i saw the right way to do it halfway through. will fix more of that later. im more caught on, how to run npm install as post install step. |
| }: | ||
|
|
||
| let | ||
| py = python.override { |
There was a problem hiding this comment.
No overrides in python-packages.nix.
| { stdenv, python }: | ||
|
|
||
|
|
||
| let |
There was a problem hiding this comment.
No overrides in python-packages.nix.
Don't. You can probably symlink to a package in |
|
What's the status of this? |
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
|
dont have time to clean this up |
|
Someone else can take over this PR? |
Motivation for this change
I wanted to play with localstack. others do to #50445
this is still a wip but thought id post here if others wanted to play while i get it working
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)