Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webxr-test-api method names to floorOrigin #17814

Merged
merged 1 commit into from Jul 13, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jul 12, 2019

Per feedback on the spec and updates to the comments about what an
origin actually is, the API method names and dictionary values were
updated from localToFloorTransform to the more accurate floorOrigin. The
current usage of these items actually matches the new name and therefore
were previously improperly named.

Bug: 979316
Change-Id: I9deedf9cf25e804135251b8e20a30d89f0eb6276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700176
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677129}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

Per feedback on the spec and updates to the comments about what an
origin actually is, the API method names and dictionary values were
updated from localToFloorTransform to the more accurate floorOrigin. The
current usage of these items actually matches the new name and therefore
were previously improperly named.

Bug: 979316
Change-Id: I9deedf9cf25e804135251b8e20a30d89f0eb6276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700176
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677129}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants