Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundlerUpdateScript: init and use #64822

Merged
merged 1 commit into from Jul 22, 2019

Conversation

nicknovitski
Copy link
Contributor

@nicknovitski nicknovitski commented Jul 15, 2019

This adds a new function which can be used as the passthru.updateScript of many simple ruby packages. It also puts that function to use in every "simple" ruby package I could find.

Though I tried to keep the changes I made minimal, I thought it would be polite to list myself as a maintainer of each package I touched.

Motivation for this change

I was working on a PR for updating fastlane (#63543), a ruby package which I use and which has frequent releases. I wrote an updateScript for it, then realized it was generalizable. I've also been hoping for semi-automated package updates in more parts of nixpkgs for a while.

Things done

I've run the scripts successfully, using nix-shell maintainers/scripts/update.nix --argstr maintainer nicknovitski

For some reason nix-review fails on attempting to evaluate the new function. I don't fully understand that.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zimbatm
Copy link
Member

zimbatm commented Jul 22, 2019

Sorry for the slow reaction. I had a look at the PR and it looks great! I'm just running nix-review to see if anything broke and I will merge afterwards.

@zimbatm zimbatm merged commit 7136e0d into NixOS:master Jul 22, 2019
@kimat kimat mentioned this pull request May 22, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants