Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncthing: 1.1.4 -> 1.2.0 #64730

Closed
wants to merge 3 commits into from
Closed

syncthing: 1.1.4 -> 1.2.0 #64730

wants to merge 3 commits into from

Conversation

emmanuelrosa
Copy link
Contributor

@emmanuelrosa emmanuelrosa commented Jul 14, 2019 •
edited

Motivation for this change

The motivation for this change is to upgrade syntching from 1.1.4 to 1.2.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Xubuntu)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
    • syncthing-init - failed; also fails with syncthing-1.1.4
    • syncthing-relay - passed
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
    • syncthing-gtk
    • qsyncthingtray
    • syncthing-tray
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after): before = 59608632, after = 61636056
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Release notes
  • This release does not interoperate with Syncthing 0.14.45 or older.
  • This release adds QUIC with NAT traversal as a new transport protocol. TCP is usually more performant and remains the preferred way of connection when possible.
  • This release adds automatic crash reporting. See https://docs.syncthing.net/users/crashrep.html for details.
  • This release makes large / variable block size the only available mode of operation; small / fixed blocks are deprecated. See https://docs.syncthing.net/advanced/folder-uselargeblocks.html for details.
  • This release reverts the version naming change in xbmcPlugins.svtplay: 4.0.6 -> 4.0.8 #4586 (v1.1.4). Versions are now named with the time of their archiving, and the file modification time is unchanged when archiving. An exception to this is the "Trashcan" versioner which does not modify the name - instead it does set the file modification time the time of archiving.

jonringer
jonringer reviewed Jul 14, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while trying to use one of the binaries, i got this error:

./results/syncthing-gtk/bin/syncthing-gtk
Traceback (most recent call last):
  File "/nix/store/fgqzbqacdxi5jy1dy84adffvjn65br3x-syncthing-gtk-0.9.4/bin/..syncthing-gtk-wrapped-wrapped", line 38, in <module>
    from syncthing_gtk.app import App
  File "/nix/store/fgqzbqacdxi5jy1dy84adffvjn65br3x-syncthing-gtk-0.9.4/lib/python2.7/site-packages/syncthing_gtk/app.py", line 9, in <module>
    from gi.repository import Gtk, Gio, Gdk, GLib, GdkPixbuf
  File "/nix/store/kikf0730sv6d1wyzhmq6f1ihv3nfrh7c-python2.7-pygobject-3.32.1/lib/python2.7/site-packages/gi/importer.py", line 140, in load_module
    raise ImportError(e)
ImportError: Typelib file for namespace 'Pango', version '1.0' not found

@emmanuelrosa
Copy link
Contributor Author

@jonringer I get the same error without this PR. How about you?

@emmanuelrosa
Copy link
Contributor Author

Confirmed the tray apps do indeed work. The only things left are syncthing-gtk and the init NixOS test. Both of which are failing due to something other than this PR, but might as well fix them :)

@emmanuelrosa
Copy link
Contributor Author

syncthing-gtk is now working :)

However, I had to manually edit the configuration generated by it's wizard (-1 command-line option) because it was incorrect; The syncthing WebUI URL port and API key were incorrect.

@emmanuelrosa
Copy link
Contributor Author

The syncthing-init NixOS test is fixed. Finished!

Emmanuel Rosa and others added 3 commits August 3, 2019 10:28
@emmanuelrosa
syncthing: 1.1.4 -> 1.2.0
a52c42f
@emmanuelrosa
syncthing-gtk: add missing runtime dependencies
3cc926a 
This commit adds various dependencies to nativeBuildInputs to
address various errors of the following form:

ImportError: Typelib file for namespace 'xxx', version 'x.y.z' not found
@emmanuelrosa
syncthing: fix syncthing-init NixOS test
f3547f6 
This commit fixes the path to the syncthing config.xml

It used to be at `/var/lib/syncthing`, but now is at
`/var/lib/syncthing/.config/syncthing`.
@manveru
Copy link
Contributor

manveru commented Aug 7, 2019

@emmanuelrosa why was this closed?

@jonringer
Copy link
Contributor

for what it's worth:

nix-review passes on NixOS
binaries seem to work

@emmanuelrosa
Copy link
Contributor Author

emmanuelrosa commented Aug 7, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emmanuelrosa @manveru @jonringer