Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dosbox: 0.74-2 -> 0.74-3, fixing CVE-2019-7165, CVE-2019-12594 #64731

Merged
merged 1 commit into from Jul 18, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jul 14, 2019

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-7165
https://nvd.nist.gov/vuln/detail/CVE-2019-12594

See also #64729

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

$ nix-review pr 64729 passes on NixOS
diff LGTM
dosbox and keen4 binaries work

[7 built, 114 copied (297.1 MiB), 63.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/64729
2 package were build:
dosbox keen4

@grahamc grahamc merged commit 3f4ed94 into NixOS:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants