Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xcape: 1.2 -> 20180301 #64805

Merged
merged 1 commit into from Jul 16, 2019
Merged

xcape: 1.2 -> 20180301 #64805

merged 1 commit into from Jul 16, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

1.2 only allows running in the foreground if debug mode is enabled which generates lots of noise for journald.

The changes from the most recent release is only a few minor fixes plus support for running in the foreground with the -f flag.

Using it here as a daily driver - all good.

Cc: @7c6f434c

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
xcape: 1.2 -> 20180301
4384bac 
1.2 only allows running in the foreground if debug mode is enabled which
generates lots of noise for journald.

The changes from the most recent release is only a few minor fixes plus support
for running in the foreground with the `-f` flag.
@ofborg ofborg bot requested a review from 7c6f434c July 15, 2019 14:52
@7c6f434c 7c6f434c merged commit be03f0a into NixOS:master Jul 16, 2019
@peterhoeg peterhoeg deleted the u/xcape branch July 16, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @7c6f434c