Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests: extend grafana test, nixos/grafana: use group grafana instead of nogroup #64810

Merged
merged 2 commits into from Jul 16, 2019

Conversation

WilliButz
Copy link
Member

Motivation for this change

#64281

Things done

This extends the grafana test with configurations for postgresql and mariadb.
Also the user grafana is now in the group grafana, because nogroup was used before.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (x86_64-linux & aarch64-linux)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @aanderse

@WilliButz
Copy link
Member Author

@GrahamcOfBorg test grafana

@WilliButz
Copy link
Member Author

@GrahamcOfBorg test grafana

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me 👍 I ran the test locally and it passed 👍

Thanks for doing this!

@aanderse aanderse merged commit ee12318 into NixOS:master Jul 16, 2019
@WilliButz WilliButz deleted the grafana-extend-test branch July 16, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants