Example #64678

cc @timokau let's see if anything breaks

In that case you also want to drop the builtins.trace deprecation warning from lib.nixpkgsVersion.

So if I see this correctly, this is mostly a naming issue (a.k.a not everything from lib should be in the global "namespace"), not a direct problem with my change right? I have to admit that I don't remeber the exact reasons why I did the rename back then, but given the current issues, this seems fine to me 👍

Isn't lib.version somewhat of an antipattern itself? What are valid usecases? The only one I can find/ think of is doc generation.

Isn't lib.version somewhat of an antipattern itself? What are valid usecases?

maybe not valid but fwiw I use it in out-of-tree derivations and overlays as a way of determining which hash to use for things like buildRustPackage's cargoSha256 and buildGoModule's modSha256 because I don't want to be bothered with maintaining separate branches. I also use it as a way of marking packages as broken that don't have the meta.broken and platforms attributes set correctly in the stable channel but that's just laziness and maybe I should be submitting PRs to set it for the affected packages, or push for some changes to get backported...

In that case you also want to drop the builtins.trace deprecation warning from lib.nixpkgsVersion.

Worth noting that anything using the version to target multiple nixpkgs channels will want to use lib.trivial.version instead unless the warning is also removed from the stable channel, though I suppose (lib.version or lib.nixpkgsVersion) works too.

Side note: it's silly but one option that avoids the rename might be to simply include an assertion in mkDerivation or ofborg that version should never equate to the nixpkgs version so the mistake is caught at eval time, though I think nixpkgsVersion is more clear as a name anyway so...

Another argument for removing lib.version (and lib.nixpkgsVersion) is that eventually we may want to move the library into its own repository (i.e. as a separate flake) so it can be used outside of Nixpkgs/NixOS.

@FRidh should this be merged or closed? Feedback seems split.

I marked this as stale due to inactivity. → More info