python.pkgs.scipy: inherit the correct version #64678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the missing `rec` the inherited version was actually the nixpkgs version. AS a result, the output name depended on how nixpkgs was fetched, introducing impurity.
|
@GrahamcOfBorg build pythonPackages.scipy |
|
The issue was introduced in 28554b1 (as found by @cleverca22) |
ofborg
bot
added
6.topic: python
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
labels
|
Good catch. I think we should actually get rid of this top-level version
attribute asap because it has caused this kind of trouble more often.
…On Fri, Jul 12, 2019, 22:31 Timo Kaufmann ***@***.***> wrote:
Merged #64678 <#64678> into master.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#64678?email_source=notifications&email_token=AAQHZ36R4EPBBJC6IZQM4ILP7DS2RA5CNFSM4ICQM73KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSPJ22OI#event-2480123193>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQHZ34BKAWFKLSPFT3SPZ3P7DS2RANCNFSM4ICQM73A>
.
|
|
Followup in #64680 because I forgot to also update the fixed output hash. I wonder how this ever worked. Somehow a scipy version must have been in the nix cache under that hash.
Agreed, not sure why we would want that in |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Because of the missing
recthe inherited version was actually thenixpkgs version. AS a result, the output name depended on how nixpkgs
was fetched, introducing impurity.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)