Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderbird, thunderbird-bin: 60.7.2 -> 60.8.0 [Critical security fix] #64690

Merged
merged 2 commits into from Jul 13, 2019
Merged

thunderbird, thunderbird-bin: 60.7.2 -> 60.8.0 [Critical security fix] #64690

merged 2 commits into from Jul 13, 2019

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jul 13, 2019

Motivation for this change
  • Critical security fix
  • Other bug fix

https://www.thunderbird.net/en-US/thunderbird/60.8.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2019-23/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from edolstra and nbp July 13, 2019 01:48
@vcunat vcunat self-assigned this Jul 13, 2019
vcunat
vcunat approved these changes Jul 13, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both run OK for me.

@FRidh FRidh merged commit 07bf5ed into NixOS:master Jul 13, 2019
vcunat added a commit that referenced this pull request Jul 13, 2019
@vcunat
Merge #64690: thunderbird*: 60.7.2 -> 60.8.0 (security)
e87ed4c
vcunat added a commit that referenced this pull request Jul 13, 2019
@vcunat
Merge #64690: thunderbird*: 60.7.2 -> 60.8.0 (security)
63963b8 
(cherry picked from commit e87ed4c)
@vcunat
Copy link
Member

vcunat commented Jul 13, 2019

Also, re-tested both on 19.03 and pushed as 63963b8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees

@vcunat vcunat

Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taku0 @vcunat @FRidh