Result of nix-review 1

Result of nix-review pr 64692 1

To get python27Packages.trackpy's tests passing on darwin:

  checkPhase = stdenv.lib.optionalString stdenv.isDarwin ''
    export HOME=$(mktemp -d)
    mkdir -p $HOME/.matplotlib
    echo "backend: ps" > $HOME/.matplotlib/matplotlibrc
  '' + ''
    pytest tra...

Note I often tend to take stdenv as an argument because it not only removes the need for .lib, but also gives you useful things I often need like platform tests.

(TBH it might be worth taking the condition out of that and just doing it for all platforms as it will remove the risk of any platform attempting to e.g. open an X server)

@risicle your requested change has been made.

    # specifically needed for darwin
    export HOME=$(mktemp -d)
    mkdir -p $HOME/.matplotlib
    echo "backend: ps" > $HOME/.matplotlib/matplotlibrc

@worldofpeace this is needed for the darwin compatibility. Should I do an if stdenv.isdarwin then ... else ... instead of putting it together?

    # specifically needed for darwin
    export HOME=$(mktemp -d)
    mkdir -p $HOME/.matplotlib
    echo "backend: ps" > $HOME/.matplotlib/matplotlibrc

@worldofpeace this is needed for the darwin compatibility. Should I do an if stdenv.isdarwin then ... else ... instead of putting it together?

Yeah or even wrap it with

${lib.optionalString (stdenv.isDarwin) ''
  
''}

inside the checkPhase.

@worldofpeace changes have been made and it builds locally for me.

Result of nix-review pr 64692 1

Ready for merge