Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edk2: 2017-12-05 -> 201905 #64813

Merged
merged 1 commit into from Aug 19, 2019
Merged

edk2: 2017-12-05 -> 201905 #64813

merged 1 commit into from Aug 19, 2019

Conversation

abbradar
Copy link
Member

  • Move to stable version;
  • Refactor setup to mkDerivation;
  • Use flags instead of sed.
Motivation for this change

Did this while investigating UEFI PXE netboot testing problems.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Ran qemu with this several times during debugging and testing unrelated PR.

@abbradar
Copy link
Member Author

@GrahamcOfBorg build OVMF OVMF-CSM OVMF-secureBoot

@abbradar
Copy link
Member Author

abbradar commented Jul 15, 2019

@GrahamcOfBorg build OVMF OVMF-CSM OVMF-secureBoot

Maybe Secure Boot now works on Aarch64 too?

EDIT: yes it does, at least compiles.

* Move to stable version;
* Refactor `setup` to `mkDerivation`;
* Use flags instead of `sed`;
* Support Secure Boot builds.
@abbradar
Copy link
Member Author

This worked for me with qemu; let's merge.

@abbradar abbradar merged commit c3a6c8d into NixOS:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant