Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebKit export of bugs.webkit.org/show_bug.cgi?id=198032 #17825

Merged
merged 1 commit into from Nov 6, 2021

Conversation

pjh0718
Copy link

@pjh0718 pjh0718 commented Jul 14, 2019

This test is included in the WebKit commit below.

Always min-width should win over max-width.
https://bugs.webkit.org/show_bug.cgi?id=198032

Reviewed by Darin Adler.

In the spec, https://www.w3.org/TR/CSS21/visudet.html#min-max-widths,
the following algorithm describes how the two properties influence
the used value of the 'width' property.

1. The tentative used width is calculated (without 'min-width' and 'max-width')
following the rules under "Calculating widths and margins" above.
2. If the tentative used width is greater than 'max-width',
the rules above are applied again, but this time using the computed value of 'max-width'
as the computed value for 'width'.
3. If the resulting width is smaller than 'min-width', the rules above are applied again,
but this time using the value of 'min-width' as the computed value for 'width'.

@foolip
Copy link
Member

foolip commented Oct 25, 2019

This was landed in https://bugs.webkit.org/show_bug.cgi?id=198032 but this remains open. @pjh0718 because this is an export I think all reviewers presumed it needs no review here. I guess this PR should still be merged?

Copy link
Member

@nt1m nt1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebKit export, approving

@nt1m nt1m changed the title Export from WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=198032 WebKit export of bugs.webkit.org/show_bug.cgi?id=198032 Nov 6, 2021
@nt1m nt1m enabled auto-merge (rebase) November 6, 2021 12:17
@nt1m nt1m merged commit 61bbe18 into web-platform-tests:master Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants