Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-bloat: 0.7.1 -> 0.7.2 #64719

Merged
merged 1 commit into from Jul 14, 2019
Merged

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Jul 14, 2019

Motivation for this change

Update cargo-bloat to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

$ nix-review pr 64719 passes on NixOS
diff LGTM
binaries work

[4 built, 33 copied (383.4 MiB), 116.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/64719
1 package were build:
cargo-bloat

@worldofpeace worldofpeace merged commit 8671386 into NixOS:master Jul 14, 2019
@xrelkd xrelkd deleted the update/cargo-bloat branch July 16, 2019 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants