Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2019.07.12 -> 2019.07.16 #64718

Merged
merged 2 commits into from Jul 16, 2019
Merged

youtube-dl: 2019.07.12 -> 2019.07.16 #64718

merged 2 commits into from Jul 16, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Jul 14, 2019 •
edited

Motivation for this change

Update youtube-dl to the latest release.
https://github.com/ytdl-org/youtube-dl/releases/tag/2019.07.16
NOTE: Updates to youtube-dl should be backported, thanks!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Yarny0
Copy link
Contributor

Yarny0 commented Jul 15, 2019

Review per https://nixos.org/nixpkgs/manual/#sec-reviewing-contributions and top comment in https://raw.githubusercontent.com/NixOS/nixpkgs/master/.github/PULL_REQUEST_TEMPLATE.md .

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64-linux
  • executables tested on x86_64-linux
  • all depending packages build: only mpv
Comments
  • Notifying maintainer @Enzime (other are already listed in reviewer list).
  • Successfully tested ${youtube-dl}/bin/youtube-dl with a YouTube video.
  • Successfully tested ${mpv}/bin/mpv with a YouTube video.
  • Not tested many other depending packages.
  • I support the request for backporting.

@xrelkd xrelkd changed the title youtube-dl: 2019.07.12 -> 2019.07.14 youtube-dl: 2019.07.12 -> 2019.07.16 Jul 16, 2019
@xrelkd
Copy link
Contributor Author

xrelkd commented Jul 16, 2019

Hello, @worldofpeace, youtube-dl has been updated again.
Could you review this PR?
Thank you very much!

@worldofpeace worldofpeace merged commit 617a3a6 into NixOS:master Jul 16, 2019
@xrelkd xrelkd deleted the update/youtube-dl branch July 16, 2019 18:04
@worldofpeace
Copy link
Contributor

backported in 76cb4fe

@worldofpeace
Copy link
Contributor

Hello, @worldofpeace, youtube-dl has been updated again.
Could you review this PR?
Thank you very much!

feel free to ping me for merge/review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

@Phreedom Phreedom Awaiting requested review from Phreedom

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @Yarny0 @worldofpeace