Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: put Java software's build-time dependencies into nativeBuildInputs instead of into buildInputs #64879

Merged
merged 1 commit into from Jul 20, 2019
Merged

doc: put Java software's build-time dependencies into nativeBuildInputs instead of into buildInputs #64879

merged 1 commit into from Jul 20, 2019

Conversation

das-g
Copy link
Member

@das-g das-g commented Jul 16, 2019

Put Java software's build-time dependencies into nativeBuildInputs instead of into buildInputs in the examples of the NixPkgs manual.

Motivation for this change

jdk, ant, gcj and makeWrapper aren't needed at run-time by most Java software, even when they're being used for building the software.

See conversation at #56893 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@das-g das-g mentioned this pull request Jul 16, 2019
Merged
10 tasks
@das-g
Copy link
Member Author

das-g commented Jul 17, 2019

Thanks for the review, @FRidh. 😃

What happens now? Does this need another approval before being merged?

@FRidh
Copy link
Member

FRidh commented Jul 17, 2019

Ideally, you, as contributor, ask the maintainers of this piece to review. Who is involved in the Java infrastructure, cc them.

@das-g
Copy link
Member Author

das-g commented Jul 17, 2019 •
edited

Ideally, you, as contributor, ask the maintainers of this piece to review. Who is involved in the Java infrastructure, cc them.

Um ... kinda-still-a-newbie here, so please help me out. Do NixPkgs manual sections even have maintainers? If so, how do I find out who they are for a given section? The Python section seems to be the only one listed in .github/CODEOWNERS. And without intending offense to the maintainers of the Java section if there actually are some, but the history of the source file doesn't seem to indicate any dedicated maintainer activity, except for whole-manual cleanups that aren't specific to that section.

So whom specifically am I supposed to contact?

@FRidh
Copy link
Member

FRidh commented Jul 20, 2019

You are right, it seems to be unmaintained. Well, let's do something about then.

@FRidh FRidh merged commit b6a25f2 into NixOS:master Jul 20, 2019
@das-g das-g deleted the java-buildtime-dependencies-as-nativeBuildInputs branch July 21, 2019 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@das-g @FRidh