Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Google's Samus (aka Chromebook Pixel 2015) #113

Closed
wants to merge 3 commits into from

Conversation

kcalvinalvin
Copy link
Member

Adds support for the custom touchpad driver for Google's Samus.

@Mic92
Copy link
Member

Mic92 commented Jul 16, 2019

Thanks for the effort of putting all this configuration/documentation together.
Would it be possible to upstream the packages to nixpkgs instead?
There we have better mechanisms to update and build packages. Having a hardware profile here is fine.

#ifndef GESTURES_FINGER_METRICS_H_
#define GESTURES_FINGER_METRICS_H_

+#include <math.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also make a PR for this one? The patch looks quite trival.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hrm didn't notice that. I'll do so


postPatch = ''
substituteInPlace Makefile \
--replace -Werror -Wno-error \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugegreenbug it would be nice to have no -Werror by default in the Makefile.

Copy link
Member

@lukateras lukateras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to see all relevant packages upstreamed. Feel free to cross-reference Nixpkgs PR numbers here and/or mention @yegortimoshenko in Nixpkgs PRs: I will try my best to review and merge as fast as I can.

google/samus/README.md Outdated Show resolved Hide resolved
in

{
options.hardware.samus.cmt = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rather belongs to services.xserver.cmt by current convention.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I'll do so.

{ stdenv, fetchFromGitHub, pkgconfig, xorgserver, xorgproto,
utilmacros, libgestures, libevdevc }:

stdenv.mkDerivation rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I've tried to upstream this way back in NixOS/nixpkgs#29788, but eventually found that libinput works better on my Chromebook device. Have you tried that?

Either way, this should be upstreamed to Nixpkgs. It will bitrot and eventually break here, as an example, see inversepath/usbarmory subtree (it doesn't work anymore).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried libinput. Don't know if it's just me but the acceleration feels better with cmt. Maybe with tweaking it's possible to get it just right but to me, this feels better.

Yes will do so.

kcalvinalvin and others added 2 commits July 17, 2019 00:53
Co-Authored-By: Yegor Timoshenko <yegortimoshenko@riseup.net>
@kcalvinalvin
Copy link
Member Author

NixOS/nixpkgs#66195

Upstreamed cmt.nix to nixpkgs

@kcalvinalvin
Copy link
Member Author

I think it closes this PR if NixOS/nixpkgs#66195 gets merged

@kcalvinalvin
Copy link
Member Author

Chromebook touchpad driver support merged in:
NixOS/nixpkgs#67241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants