New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Google's Samus (aka Chromebook Pixel 2015) #113
Conversation
Thanks for the effort of putting all this configuration/documentation together. |
#ifndef GESTURES_FINGER_METRICS_H_ | ||
#define GESTURES_FINGER_METRICS_H_ | ||
|
||
+#include <math.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also make a PR for this one? The patch looks quite trival.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hrm didn't notice that. I'll do so
|
||
postPatch = '' | ||
substituteInPlace Makefile \ | ||
--replace -Werror -Wno-error \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hugegreenbug it would be nice to have no -Werror
by default in the Makefile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to see all relevant packages upstreamed. Feel free to cross-reference Nixpkgs PR numbers here and/or mention @yegortimoshenko in Nixpkgs PRs: I will try my best to review and merge as fast as I can.
google/samus/modules/cmt.nix
Outdated
in | ||
|
||
{ | ||
options.hardware.samus.cmt = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rather belongs to services.xserver.cmt
by current convention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I'll do so.
{ stdenv, fetchFromGitHub, pkgconfig, xorgserver, xorgproto, | ||
utilmacros, libgestures, libevdevc }: | ||
|
||
stdenv.mkDerivation rec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! I've tried to upstream this way back in NixOS/nixpkgs#29788, but eventually found that libinput works better on my Chromebook device. Have you tried that?
Either way, this should be upstreamed to Nixpkgs. It will bitrot and eventually break here, as an example, see inversepath/usbarmory
subtree (it doesn't work anymore).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried libinput. Don't know if it's just me but the acceleration feels better with cmt. Maybe with tweaking it's possible to get it just right but to me, this feels better.
Yes will do so.
Co-Authored-By: Yegor Timoshenko <yegortimoshenko@riseup.net>
Upstreamed cmt.nix to nixpkgs |
I think it closes this PR if NixOS/nixpkgs#66195 gets merged |
Chromebook touchpad driver support merged in: |
Adds support for the custom touchpad driver for Google's Samus.