Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pantheon.cerbere: 0.2.4 -> 2.5.0 #64707

Merged
merged 1 commit into from Aug 3, 2019
Merged

pantheon.cerbere: 0.2.4 -> 2.5.0 #64707

merged 1 commit into from Aug 3, 2019

Conversation

worldofpeace
Copy link
Contributor

Fixes #60955

Motivation for this change

Upstream should have fixes for #60955 but it seemed like it was still timing out on my
system so I've opened this for feedback. If it's the case that it's not actually fixed I should
be able to re-open the issue upstream.

https://github.com/elementary/cerbere/releases/tag/2.5.0

  • Handle SIGHUP and SIGTERM to prevent hang on system shutdown
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace added this to In progress in Pantheon via automation Jul 13, 2019
@worldofpeace
Copy link
Contributor Author

cc @davidak.

I'm not sure if this actually was fixing the issue #60955.
Though perhaps other programs in pantheon need fixes like this.

@davidak
Copy link
Member

davidak commented Aug 2, 2019

I build my system with this branch and it fixes the problem. Shutdown takes now about 2 seconds. It took very long before. I had no program open.

The test system is this: https://github.com/davidak/nixos-config/blob/master/machines/imac/configuration.nix (using systemd-boot)

davidak
davidak approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes the problem for me. Change also looks sane.

@worldofpeace
Copy link
Contributor Author

Thank you @davidak ✨

I currently lack testers for Pantheon (I've been pushing things that I've only manually tested)
so it would be a great help to continue this if you'd like.

@worldofpeace worldofpeace merged commit f8de228 into NixOS:master Aug 3, 2019
Pantheon automation moved this from In progress to Done Aug 3, 2019
@worldofpeace worldofpeace deleted the cerbere-fix branch August 3, 2019 01:36
@worldofpeace
Copy link
Contributor Author

backported in 4f2b76e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

Assignees
No one assigned
Labels
6.topic: pantheon The Pantheon desktop environment 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
Pantheon
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pantheon: shutdown always times out
2 participants
@worldofpeace @davidak