Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating documentation about adding new Vim plugins #64753

Merged
merged 2 commits into from Aug 2, 2019
Merged

Updating documentation about adding new Vim plugins #64753

merged 2 commits into from Aug 2, 2019

Conversation

malob
Copy link
Member

@malob malob commented Jul 15, 2019

Motivation for this change

Documentation about adding Vim plugins to nixpkgs was out of date and scant on details.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This information is accurate from my own experiences with how vim-plugins are structured.

Thanks for doing this! :)

@malob
Copy link
Member Author

malob commented Aug 2, 2019

Anything I can do the to help move this along?

@jonringer
Copy link
Contributor

Not sure who to CC, I would find who has commit access and is interested in vim plugins by looking at some of the commits, then ping them. With the volume of PRs, many fall through the cracks :(

@7c6f434c
Copy link
Member

7c6f434c commented Aug 2, 2019

Not that I care about Vim plugins…

@7c6f434c 7c6f434c merged commit 6664484 into NixOS:master Aug 2, 2019
@malob malob deleted the update-add-vim-plugin-docs branch August 3, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: vim 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@malob @jonringer @7c6f434c @teto