Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beam-packages: default erlangR20 -> erlangR22 #64801

Merged
merged 4 commits into from Jul 18, 2019

Conversation

yorickvP
Copy link
Contributor

Motivation for this change

Last time: #44640
This has worked for us since february, it's time to upstream it. R22 was released in the meantime.

cc: @LnL7 @ankhers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yorickvP yorickvP changed the title beam-packages: default erlangR20 -> erlangR21 beam-packages: default erlangR20 -> erlangR22 Jul 15, 2019
@yorickvP
Copy link
Contributor Author

Actually, R22 shouldn't break too much.

@ankhers
Copy link
Contributor

ankhers commented Jul 15, 2019

I am all for this.

We should probably come up with some way to update the major version of Erlang sooner. I cannot seem to find a link at the moment, but I think the last time someone suggested updating Erlang it was somewhat shot down because we were unsure of the total changes it would have to the entire ecosystem.

@yorickvP
Copy link
Contributor Author

@GrahamcOfBorg build cuter rabbitmq-server ejabberd couchdb2 tsung hex2nix

@yorickvP
Copy link
Contributor Author

couchdb got fixed in apache/couchdb@9d143ba

@yorickvP
Copy link
Contributor Author

hex2nix fix: erlang-nix/hex2nix#27

@yorickvP
Copy link
Contributor Author

@GrahamcOfBorg build relxExe couchdb2

@yorickvP
Copy link
Contributor Author

@GrahamcOfBorg build hex2nix

@yorickvP
Copy link
Contributor Author

This is done, as far as I can tell :)

@LnL7
Copy link
Member

LnL7 commented Jul 18, 2019

I'm not super familiar with the erlang ecosystem, but for most languages we don't upgrade the default version immediately. Following n-1 might be a good rule of thumb, but I'm not aware of any particular reason not to go a bit faster.

@LnL7 LnL7 merged commit 8c4152d into NixOS:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants