qtcreator: 4.6.2 -> 4.9.0 #61448
Closed
qtcreator: 4.6.2 -> 4.9.0 #61448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on my local machine.
|
The commit message should state what you updated :) |
jtojnar
reviewed
May 13, 2019
| @@ -6,8 +6,8 @@ | |||
| with stdenv.lib; | |||
|
|
|||
| let | |||
| baseVersion = "4.6"; | |||
There was a problem hiding this comment.
It might make sense to do what GNOME packages do: define a single version attribute and split it where needed. It will allow us to us update-source-version program.
|
Sorry about the lousy commit message earlier. I do not have the repo checked out locally so I created #61453 this. Thanks, bye. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am very new to Nix and don't have a lot of experience so let me know if any changes are required. The only testing I have done is on my local machine taking it from 4.6 to 4.9. It compiles fine and runs (for a few minutes so far).
Added myself as a maintainer so the package should stay up to date in future.