webrtc wpt: add missing pc.close during cleanup #16815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 14, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1610767
branch
from
ba6272b
to
aaf95d3
Compare
running the html.js/codemod-peerconnection-addcleanup from the tools directory showed some places where a pc.close was missing BUG=836871 Change-Id: I135db200a4269eccfafc43217b66584603101434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610767 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#661283}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1610767
branch
from
aaf95d3
to
4665f4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
running the html.js/codemod-peerconnection-addcleanup from the tools directory showed some places where a pc.close was missing
BUG=836871
Change-Id: I135db200a4269eccfafc43217b66584603101434
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610767
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661283}