Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor mathcomp packages #61456

Closed
wants to merge 1 commit into from
Closed

refactor mathcomp packages #61456

wants to merge 1 commit into from

Conversation

CohenCyril
Copy link
Contributor

Motivation for this change

This PR splits the coq mathcomp package in several packages (as in the opam repositories) as they are meant to be, and creates a common package generator for them. We also give a template to generate extra mathcomp user contributed packages using a few meta data.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CohenCyril
Copy link
Contributor Author

@vbgl I shall stop here and ask for advice...

@CohenCyril
Copy link
Contributor Author

@vbgl what do you think?

@vbgl
Copy link
Contributor

vbgl commented May 15, 2019

Merged as b71c308

@vbgl vbgl closed this May 15, 2019
vbgl pushed a commit that referenced this pull request May 15, 2019
@CohenCyril @vbgl
coqPackages: refactor mathcomp packages
b71c308 
Closes #61456
tadeokondrak pushed a commit to tadeokondrak/nixpkgs that referenced this pull request May 17, 2019
@CohenCyril @tadeokondrak
coqPackages: refactor mathcomp packages
187296e 
Closes NixOS#61456
@CohenCyril CohenCyril deleted the mathcomp_update branch May 23, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CohenCyril @vbgl