Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitwarden_rs: 1.8.0 -> 1.9.0 #61353

Merged
merged 2 commits into from May 12, 2019
Merged

bitwarden_rs: 1.8.0 -> 1.9.0 #61353

merged 2 commits into from May 12, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented May 12, 2019

Motivation for this change

To go with #60959
cc @msteen @marsam

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

marsam
marsam approved these changes May 12, 2019
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've added a fix for the darwin build. I hope you don't mind
Tested locally on NixOS and darwin

@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 12, 2019

No problem. Thanks for the test on Darwin

@dywedir
Copy link
Member

dywedir commented May 12, 2019

Thanks!

@dywedir dywedir merged commit fd4a976 into NixOS:master May 12, 2019
@c0bw3b c0bw3b deleted the pkg/bitwardenrs branch May 12, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @dywedir @marsam