Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ldc #61354

Merged
merged 2 commits into from May 12, 2019
Merged

Fix ldc #61354

merged 2 commits into from May 12, 2019

Conversation

ThomasMader
Copy link
Contributor

Motivation for this change

This fixes the ldc build. #61316
Also enabled the dmd testsuite for the dmd package because #56744 fixed that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ThomasMader
Copy link
Contributor Author

@GrahamcOfBorg build ldc dmd

@ThomasMader
Copy link
Contributor Author

It would be nice if #59390 could be merged as well.

@c0bw3b c0bw3b merged commit b6e415a into NixOS:master May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants