Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nyancat: init at 1.5.2 #61356

Merged
merged 1 commit into from May 16, 2019
Merged

nyancat: init at 1.5.2 #61356

merged 1 commit into from May 16, 2019

Conversation

midchildan
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

As cool as this is, I'd feel bad for slowing down everybody's nixos-rebuild for this..

How about using NUR instead?

@midchildan
Copy link
Member Author

If modules are the main source for the slowdown, would it be acceptable if I just remove the module? The module is just for enabling the telnet server, which is an optional component for this package. I'm totally fine with using NUR if this doesn't work out, though.

@infinisil
Copy link
Member

Yeah only modules are a slowdown for nixos-rebuild

@midchildan
Copy link
Member Author

The module is now removed :)

pkgs/tools/misc/nyancat/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/nyancat/default.nix Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented May 14, 2019

The module is now removed :)

Would you like to add module to NUR then?

@infinisil
Copy link
Member

I mean, not putting the module in nixpkgs due to the current performance problems is just my opinion. If a lot of people want the module in nixpkgs we can do that too.

@ghost
Copy link

ghost commented May 14, 2019

I mean, not putting the module in nixpkgs due to the current performance problems is just my opinion. If a lot of people want the module in nixpkgs we can do that too.

This service is more fun than something practical. I would be ok with having it only via nur

@midchildan
Copy link
Member Author

Would you like to add module to NUR then?

Not really, since I don't plan to use the telnet functionality myself. I initially included the module because other distributions like Arch and Debian did the same.

@infinisil
Copy link
Member

@GrahamcOfBorg build nyancat

@infinisil infinisil merged commit 986bde0 into NixOS:master May 16, 2019
@midchildan midchildan deleted the add-nyancat branch May 17, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants