Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calcurse: fix python3 wrapper #61352

Merged
merged 1 commit into from May 12, 2019
Merged

calcurse: fix python3 wrapper #61352

merged 1 commit into from May 12, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented May 12, 2019 •
edited

Motivation for this change

The current Python wrapper for httplib2 breaks when running e.g.
./result/bin/calcurse-caldav with the following error:

Traceback (most recent call last):
  File "./result/bin/calcurse-caldav", line 6, in <module>
    import httplib2
ModuleNotFoundError: No module named 'httplib2'

The easiest workaround is to use the wrapPython tool to properly patch
library path inside the script.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
calcurse: fix python3 wrapper
99eed6a 
The current Python wrapper for `httplib2` breaks when running e.g.
`./result/bin/calcurse-caldav` with the following error:

```
Traceback (most recent call last):
  File "./result/bin/calcurse-caldav", line 6, in <module>
    import httplib2
ModuleNotFoundError: No module named 'httplib2'
```

The easiest workaround is to use the `wrapPython` tool to properly patch
library path inside the script.
@risicle
Copy link
Contributor

risicle commented May 12, 2019

Works for me, non-nixos linux x86_64 - and much neater 👍

@FRidh FRidh merged commit c99a01a into NixOS:master May 12, 2019
@Ma27 Ma27 deleted the fix-calcurse-caldav-wrapper branch May 12, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @risicle @FRidh