Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

servant-auth-server: fix darwin build #61383

Merged
merged 1 commit into from May 13, 2019
Merged

servant-auth-server: fix darwin build #61383

merged 1 commit into from May 13, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented May 12, 2019

Motivation for this change

servant-auth-server test suite fails on darwin https://gist.github.com/marsam/ef547f3665aa9b7032b6799094cf9cc0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
haskell: x509-system fix on darwin
6673cc8 
x509-system requires access to the `security` executable. Partially
reverts [1: d69cc77]

1: d69cc77
   Revert "Revert "darwin 10.12 commits""
@marsam marsam requested a review from basvandijk as a code owner May 12, 2019 16:26
@matthewbauer
Copy link
Member

This looks like something is messed up with finding /usr/bin/security. I thought it was able to find it correctly?

@matthewbauer
Copy link
Member

I think this override is still needed:

d69cc77#diff-607a8b2e94748382228f44039b753cf0

@marsam marsam force-pushed the fix-darwin-haskell-servant-auth-server branch from cfb584a to 6673cc8 Compare May 12, 2019 19:17
@marsam
Copy link
Contributor Author

marsam commented May 12, 2019

Thanks! that indeed fixes it. I've partially reverted that change

@matthewbauer matthewbauer merged commit a688ee7 into NixOS:master May 13, 2019
@matthewbauer
Copy link
Member

Thanks!

@marsam marsam deleted the fix-darwin-haskell-servant-auth-server branch May 31, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: haskell 10.rebuild-darwin: 101-500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @matthewbauer