Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-bloat: 0.6.3 -> 0.6.4 #61459

Merged
merged 1 commit into from May 15, 2019
Merged

cargo-bloat: 0.6.3 -> 0.6.4 #61459

merged 1 commit into from May 15, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented May 13, 2019 •
edited

Motivation for this change

Update cargo-bloat to the latest release.
https://github.com/RazrFalcon/cargo-bloat/releases/tag/v0.6.4

I want to add another useful cargo subcommand cargo-make into nixpkgs.
Can anyone review #61265, if possible?
Thank you!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented May 13, 2019

@GrahamcOfBorg build cargo-bloat

@marsam marsam merged commit d284b3c into NixOS:master May 15, 2019
@marsam
Copy link
Contributor

marsam commented May 15, 2019

it was a bump release: RazrFalcon/cargo-bloat@v0.6.3...v0.6.4, tested on darwin and NixOS nonetheless
Thanks!

@xrelkd xrelkd deleted the update/cargo-bloat branch May 15, 2019 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @FRidh @marsam