@GrahamcOfBorg build infra-arcana
Not sure if I have access...

Please, add yourself to the maintainer list in a separate commit.

@GrahamcOfBorg build infra-arcana

Please, add yourself to the maintainer list in a separate commit.

Should it be in a separate PR or just a separate commit in this PR?

A seperate commit on this PR would be fine.

cc-by-nc-30 = spdx {
spdxId = "CC-BY-NC-3.0";
fullName = "Creative Commons Attribution Non Commercial 3.0 Unported";
free = false;
};

so it seems bot won't test it. Thanks for contributing.

A seperate commit on this PR would be fine.

Done :)

cc-by-nc-30 = spdx {
spdxId = "CC-BY-NC-3.0";
fullName = "Creative Commons Attribution Non Commercial 3.0 Unported";
free = false;
};

so it seems bot won't test it. Thanks for contributing.

Does that mean we can't proceed?

No, that only mean i don't :)

Well, after the earlier IRC discussion I ended up changing this to track master instead of the stable version, since there are many improvements. The developer lists master as the intended GA version on his website, so this is a supported way of running. The build process has changed since the last stable release.

I'm still using graphicsmagick to generate the PNG icons, which I will work to fix upstream.

I've discovered a bigger problem, however. The game expects the user directory to be writable for storing save files, preferences etc. There's no provision for having this directory exist per-user at all. This is a bigger thing to fix - basically adding XDG user directory support. I may look into working on this, but I'll need to talk to the developer to see if he's even interested first.

I guess this PR should be closed for now, and I can reopen it if/when the upstream changes have happened?

I think you can just let the PR opened. Btw, could be easiest to do a small substitutioninplace with a getenv(XDG_CONFIG_HOME) ( look i'm also do such thing for stuff i package ColinPitrat/caprice32#137 ) . If you can point me where is the path, i'll have a look.

The user directory is defined here: https://gitlab.com/martin-tornqvist/ia/blob/38f192f1d5b3d20739074c35b5b2a70d997ea3a0/src/paths.cpp#L25

Thanks for the link, I'll have a look at how it's implemented there (and with other projects) to get some ideas.

Pull request to fix the user directory submitted: https://gitlab.com/martin-tornqvist/ia/merge_requests/210

I won't include it as a patch just yet as it needs a little work. Once it's ready I'll add it to the derivation.

Icon patch is still TODO.

Not sure if that patch is going to go anywhere or not. I'll close this PR for now so it's not adding to the clutter, and re-open it if things start moving.