Reland "[EventTiming] Fix programmatic click test" #16803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 13, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1610022
branch
from
8f498a4
to
994c03d
Compare
This is a reland of 3bd9684c7217ec6229e50ff21c4f905855d7c133 The failure was not getting an entry for click: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/13241 Thus, we instead look at the mousedown. Since mousedown can be the first input, we stop observing for firstInput but check that entry separately as well. Original change's description: > [EventTiming] Fix programmatic click test > > Commits aee8357d3fcb0967069d7f72e2f7fab019d61c4e and > faed29aa6dc92cbae6e313b401d23df99e973bc1 landed almost at the same time, > so we accidentally landed a test with the wrong script src for the > helper functions. > > Bug: 961547 > Change-Id: Id8a615477a54e56139d9d90fc4feb5f780b729a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606225 > Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658761} Bug: 961547 Change-Id: I11f1a5f28e7e4e5ebda28c90555d89669142cc09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610022 Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#659680}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1610022
branch
from
994c03d
to
14102d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of 3bd9684c7217ec6229e50ff21c4f905855d7c133
The failure was not getting an entry for click:
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/13241
Thus, we instead look at the mousedown. Since mousedown can be the first
input, we stop observing for firstInput but check that entry separately
as well.
Original change's description:
Bug: 961547
Change-Id: I11f1a5f28e7e4e5ebda28c90555d89669142cc09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610022
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659680}