Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql: enable pre-install checks #61395

Merged
merged 1 commit into from May 14, 2019
Merged

postgresql: enable pre-install checks #61395

merged 1 commit into from May 14, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 12, 2019

Motivation for this change

Postgres' pre-install checks are quite minimal but could catch basic problems early. For some reason the make target detection thinks make check doesn't exist, so I need to set it explicitly.

Tests pass reliably for me on non-nixos linux x86_64 & macos 10.13, from postgres 11 all the way back to 9.4.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

You should set checkTarget instead i think.

@ofborg ofborg bot requested review from ocharles and danbst May 12, 2019 20:54
@risicle risicle force-pushed the ris-postgres-enable-check branch from 33efe9a to 3c33718 Compare May 12, 2019 21:10
@risicle
Copy link
Contributor Author

risicle commented May 12, 2019

Well whaddya know...

Done.

worldofpeace
worldofpeace previously requested changes May 13, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the base of your change to staging. This is mass rebuilding change according to the automatic labels.

@risicle risicle force-pushed the ris-postgres-enable-check branch from 3c33718 to d7f36ec Compare May 13, 2019 18:43
@risicle risicle changed the base branch from master to staging May 13, 2019 18:43
@risicle
Copy link
Contributor Author

risicle commented May 13, 2019

Cool - just wanted to start off with something that's quick for people to build & verify (now I know I can switch a PR's target...)

thoughtpolice
thoughtpolice approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@thoughtpolice thoughtpolice dismissed worldofpeace’s stale review May 14, 2019 19:48

Branch has been rebased

@thoughtpolice thoughtpolice merged commit 3b0b55d into NixOS:staging May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@worldofpeace worldofpeace worldofpeace left review comments

@ocharles ocharles Awaiting requested review from ocharles

@danbst danbst Awaiting requested review from danbst

@alyssais alyssais Awaiting requested review from alyssais

@FRidh FRidh Awaiting requested review from FRidh

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: python 6.topic: ruby 6.topic: vim 8.has: clean-up 8.has: documentation 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@risicle @matthewbauer @thoughtpolice @worldofpeace