Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gimpPlugins.resynthesizer: drop #61365

Merged
merged 4 commits into from May 17, 2019
Merged

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented May 12, 2019

Motivation for this change

It breaks resynthesiser2 and there is actually no reason to keep the ancient version.

bootchk/resynthesizer#63 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @jluttine

@jluttine
Copy link
Member

#61341 (comment)

@jtojnar
Copy link
Contributor Author

jtojnar commented May 12, 2019 via email

@7c6f434c
Copy link
Member

I looked at the details — «fit output to border pixels» is something that was removed from the 2.x UI, I assumed it doesn't fit the new and improved algorithm (and for the stated purpose of the plugin it might have been useless anyway)

@bootchk
Copy link

bootchk commented May 12, 2019

I am the maintainer of resynthesizer, not the original author, but the author of the maintained code. I am rather sure that nothing was removed. "fit output to border" : the engine still takes that parameter (called useBorder) but has a few more values, and the GUI of the control panel still lets you specify values, if obliquely. There WERE some behavior changes in the engine (it no longer inverts the selection on the source image) but that only affected hard core users of the control panel, and has since been thoroughly explained and users can still do all that they ever could do. Its been so long since 0.16 that I could be mistaken, if you have a test case that fails, I am interested.

@7c6f434c
Copy link
Member

Oh thank you, I just assumed that my preferences are too strange and used the old version. As far as I remember (I was experimenting together with a coworker a few years back — it was ornament completion or something like that, if I remember correctly) the new version definitely worked OK per se, but it was easier to find the settings for an output we would like with 0.16 than with then-current 2.x

@infinisil infinisil merged commit 9110185 into NixOS:master May 17, 2019
@jtojnar jtojnar deleted the drop-resynth-0 branch May 17, 2019 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants