New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gimpPlugins.resynthesizer: drop #61365
Conversation
It breaks resynthesiser2 and there is actually no reason to keep the ancient version. bootchk/resynthesizer#63 (comment)
I would say that is too vague. If such regression exists, it ought to be
reported. I am reluctant to keep ancient unmaintained packages just because
there is a possibility of regression.
Anyone who encounters an issue and cannot wait for it to be fixed can
always fetch the package from older revision of nixpkgs.
…On Sun, 12 May 2019, 16:43 Jaakko Luttinen, ***@***.***> wrote:
#61341 (comment)
<#61341 (comment)>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#61365 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAFMEY3HUTU3QQYIBBF7G3TPVAUJ3ANCNFSM4HMKJD6A>
.
|
I looked at the details — «fit output to border pixels» is something that was removed from the 2.x UI, I assumed it doesn't fit the new and improved algorithm (and for the stated purpose of the plugin it might have been useless anyway) |
I am the maintainer of resynthesizer, not the original author, but the author of the maintained code. I am rather sure that nothing was removed. "fit output to border" : the engine still takes that parameter (called useBorder) but has a few more values, and the GUI of the control panel still lets you specify values, if obliquely. There WERE some behavior changes in the engine (it no longer inverts the selection on the source image) but that only affected hard core users of the control panel, and has since been thoroughly explained and users can still do all that they ever could do. Its been so long since 0.16 that I could be mistaken, if you have a test case that fails, I am interested. |
Oh thank you, I just assumed that my preferences are too strange and used the old version. As far as I remember (I was experimenting together with a coworker a few years back — it was ornament completion or something like that, if I remember correctly) the new version definitely worked OK per se, but it was easier to find the settings for an output we would like with 0.16 than with then-current 2.x |
Motivation for this change
It breaks resynthesiser2 and there is actually no reason to keep the ancient version.
bootchk/resynthesizer#63 (comment)
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)cc @jluttine