Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miniupnpc_2: 2.1 -> 2.1.20190408, miniupnpd: 2.1 -> 2.1.20190502 #61363

Merged
merged 3 commits into from May 16, 2019
Merged

miniupnpc_2: 2.1 -> 2.1.20190408, miniupnpd: 2.1 -> 2.1.20190502 #61363

merged 3 commits into from May 16, 2019

Conversation

aanderse
Copy link
Member

Motivation for this change

#57320

@bobvanderlinden as the listed maintainer of the nixos upnp test do you know any reason that we should maintain the miniupnpc 1.x package from 2016? If you can't think of any reasons I'll replace my last commit with a commit to drop the 1.x package.

ping @dtzWill as potential interested party because of comments on #57320

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b c0bw3b mentioned this pull request May 12, 2019
Closed
@aanderse
Copy link
Member Author

@GrahamcOfBorg build altcoins.bitcoind altcoins.wownero

@aanderse
Copy link
Member Author

@GrahamcOfBorg test upnp

@bobvanderlinden
Copy link
Member

@aanderse Nope, no reason why the test is using miniupnpc 1. I wasn't aware of the 2. Apparently there was a reason to switch to switch nixpkgs' miniupnpc to version 1 and let version 2 reside under miniupnpc_2. See 53b059a

That said, this PR looks good to me 👍

@bobvanderlinden
Copy link
Member

bobvanderlinden commented May 12, 2019 •
edited

Looking at the repository of miniupnpc I couldn't find a reason why there was no release (new version) yet. Any ideas?

@aanderse
Copy link
Member Author

So now I noticed miniupnpc is actually pointing to miniupnpc_1 which means unless explicitly pointing to version 2.x everything is using 1.x (which is really old). After doing a quick search it seems many packages are using version 1.x so dropping the 1.x series is beyond the scope of this PR.

I don't know the different between the 1.x series and 2.x series. I assume a project rewrite or some such? It probably makes sense to eventually drop the 1.x series... if anyone is up to the task of ensuring everything still works on the 2.x series.

@bobvanderlinden
Copy link
Member

@Mic92 Do you know why it was decided to make miniupnpc 1 the default?

@aanderse Apart from 1 vs 2, it is still unclear for.me why 2.1.20190502 is not a official release according to the GitHub releases of miniupnp. 2.1 is an official release.

@aanderse
Copy link
Member Author

I'm basing it off the official website http://miniupnp.free.fr/ on the download page. Unless the website were to explicitly state github is the official source I would continue to use the main website as the most up to date source I guess... but yes I agree it is odd the github page doesn't have that release.

@bobvanderlinden
Copy link
Member

Aah, I see. GitHub tags/releases aren't used. For anyone else, the changelog can be found here: http://miniupnp.free.fr/files/changelog.php?file=miniupnpd-2.1.20190502.tar.gz

Thanks for the information. This looks good 👍.

@aanderse aanderse merged commit ed6ccd1 into NixOS:master May 16, 2019
@aanderse aanderse deleted the miniupnpc branch May 16, 2019 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobvanderlinden bobvanderlinden bobvanderlinden approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @bobvanderlinden